Skip to content

Extract DevelopmentStatus as a constant to scripts/constants.py#89

Merged
mbohlool merged 1 commit into
kubernetes-client:masterfrom
mbohlool:master
Jan 10, 2017
Merged

Extract DevelopmentStatus as a constant to scripts/constants.py#89
mbohlool merged 1 commit into
kubernetes-client:masterfrom
mbohlool:master

Conversation

@mbohlool

Copy link
Copy Markdown
Contributor

Having all release related constant in one place make the release process easier and much less error-prone.

cc: @dims

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 10, 2017
@codecov-io

codecov-io commented Jan 10, 2017

Copy link
Copy Markdown

Current coverage is 94.68% (diff: 100%)

Merging #89 into master will not change coverage

@@             master        #89   diff @@
==========================================
  Files             9          9          
  Lines           658        658          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            623        623          
  Misses           35         35          
  Partials          0          0          

Powered by Codecov. Last update 420d491...58aa165

@dims

dims commented Jan 10, 2017

Copy link
Copy Markdown
Collaborator

LGTM 👍

@mbohlool mbohlool added lgtm "Looks good to me", indicates that a PR is ready to be merged. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 10, 2017
@mbohlool
mbohlool merged commit a25d5eb into kubernetes-client:master Jan 10, 2017
@mbohlool mbohlool mentioned this pull request Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants