Skip to content

Use yaml.safe_load#719

Merged
k8s-ci-robot merged 1 commit into
kubernetes-client:masterfrom
ramnes:use-safe-load
Jan 9, 2019
Merged

Use yaml.safe_load#719
k8s-ci-robot merged 1 commit into
kubernetes-client:masterfrom
ramnes:use-safe-load

Conversation

@ramnes

@ramnes ramnes commented Jan 8, 2019

Copy link
Copy Markdown
Contributor

See #718 for rationale.

@micw523

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 8, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 8, 2019
@micw523

micw523 commented Jan 8, 2019

Copy link
Copy Markdown
Contributor

Could you leave the one in utils in its original form just for now? #673 will change the use of load into load_all which should be fine when it gets merged. The other two look good to me.

@ramnes

ramnes commented Jan 8, 2019

Copy link
Copy Markdown
Contributor Author

@micw523 If you change #673 to use safe_load_all rather than load_all, then yes! Otherwise, I can just rebase on your PR when it's inside the tree.

@micw523

micw523 commented Jan 8, 2019

Copy link
Copy Markdown
Contributor

@ramnes sounds good! I'll make the change in #673.

micw523 added a commit to micw523/python that referenced this pull request Jan 8, 2019
@ramnes

ramnes commented Jan 9, 2019

Copy link
Copy Markdown
Contributor Author

@micw523 done

@yliaog

yliaog commented Jan 9, 2019

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2019
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ramnes, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2019
@k8s-ci-robot
k8s-ci-robot merged commit 430544b into kubernetes-client:master Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants