Skip to content

Add notebook on how to watch changes to an object #281

Merged
mbohlool merged 1 commit into
kubernetes-client:masterfrom
djkonro:watch
Aug 28, 2017
Merged

Add notebook on how to watch changes to an object #281
mbohlool merged 1 commit into
kubernetes-client:masterfrom
djkonro:watch

Conversation

@djkonro

@djkonro djkonro commented Jul 5, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 5, 2017
@djkonro

djkonro commented Jul 5, 2017

Copy link
Copy Markdown
Contributor Author

Work in process (WIP)

@mbohlool mbohlool changed the title Add watch notebook [WIP] Add watch notebook Jul 5, 2017
@djkonro djkonro changed the title [WIP] Add watch notebook Add notebook on how to watch changes to an object Jul 6, 2017
@sebgoa

sebgoa commented Aug 17, 2017

Copy link
Copy Markdown
Contributor

Sorry for the delay, you should add more information about what a watch is. Which resources can you watch ? etc.

Also the main issue here is that you only receive a fix amount of events and then exit. We need to figure out how to keep the stream open so that new events get received. It should not exit when the counter is 0.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 26, 2017
@djkonro

djkonro commented Aug 26, 2017

Copy link
Copy Markdown
Contributor Author

@sebgoa I have updated the notebook.

@sebgoa

sebgoa commented Aug 27, 2017

Copy link
Copy Markdown
Contributor

ok approved, a bit minimalist but ok.

/lgtm

@mbohlool
mbohlool merged commit 6ed1f20 into kubernetes-client:master Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants