Use oauth2 from google-auth#278
Conversation
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
cla coming |
|
signed |
d2d209d to
be87885
Compare
|
I have signed the cla with my gmail, maybe things are slow. |
|
@mbohlool Tests are passing locally, I guess I'm doing something wrong with the submodule. It is strange the requirement is in this repo but the it is used in the other repo. Is this a chicken-egg problem? |
|
Yeah, you need to send a PR to the base repo first. Here is the base repo: https://github.com/kubernetes-client/python-base/tree/master If you want to know why we have this submodule you can read this: https://github.com/kubernetes/community/blob/master/contributors/design-proposals/csi-client-structure-proposal.md |
|
I sent one [1], but how is it going to pass the tests since the requirements are in this repo? |
|
Good point. We don't have a clean way to do it. Have you tried it on a cluster that uses Google Credentials? Our tests does not cover that yet. I can test it manually tomorrow. |
|
I'll create/delete/list some pods/deployments/svcs |
|
Thanks, let me know if it worked. We may need to do some tricks to get this in (like add dependency first in this repo without removing old dependency, then merge it and update base repo, then another change in this repo to remove old dependency and update submodule). |
|
It is better in a paste. http://paste.openstack.org/raw/614620/ Also run these tests [1] without oauth2client. [1] https://github.com/openstack/magnum/blob/master/magnum/tests/functional/python_client_base.py#L30 |
36ff067 to
5bdf09d
Compare
oauth2client is deprecated [1], use google-auth. When kubernetes-client/base-python is updated to not use oauth2client, remove oauth2client. [1] https://github.com/google/oauth2client/releases (see Note) Closes: kubernetes-client#275 Signed-off-by: Spyros Trigazis <spyridon.trigazis@cern.ch>
|
When this is in we can update python-base. |
In kubernetes-client#278 google-auth was added in requirements and in [1] python-base stopped using it. Remove oauth2client requirement and update submodule commit. [1] kubernetes-client/python-base#16 Related-Issue: kubernetes-client#275 Signed-off-by: Spyros Trigazis <spyridon.trigazis@cern.ch>
In #278 google-auth was added in requirements and in [1] python-base stopped using it. Remove oauth2client requirement and update submodule commit. [1] kubernetes-client/python-base#16 Related-Issue: #275 Signed-off-by: Spyros Trigazis <spyridon.trigazis@cern.ch>
oauth2client is deprecated [1], use google-auth.
[1] https://github.com/google/oauth2client/releases (see Note)
Closes: #275
Signed-off-by: Spyros Trigazis spyridon.trigazis@cern.ch