Move config and watch into a base folder to prepare for multi-repo client#215
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
=======================================
Coverage 94.56% 94.56%
=======================================
Files 9 9
Lines 681 681
=======================================
Hits 644 644
Misses 37 37
Continue to review full report at Codecov.
|
Contributor
Author
|
@dims this is ready to review. |
Collaborator
|
Looks like just things moving around :) /lgtm |
Contributor
Author
|
Thanks |
yliaog
pushed a commit
to yliaog/client-python
that referenced
this pull request
Jan 8, 2022
…e-exception dynamic-e2e: fix the error expectation in the discovery retry logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to separate our base and generated code so other users can create their own client and use our base utilities. This is a required restructuring explained here:
https://github.com/kubernetes-client/community/blob/master/design-docs/clients-library-structure.md
configandwatchpackage has been moved into abasepackage as well asapi_clientrestandconfigurationclasses. Symlinks created to make everything work as before.