Skip to content

Switch to minikube/localkube#123

Merged
mbohlool merged 1 commit into
kubernetes-client:masterfrom
dims:try-localkube-for-e2e
Feb 9, 2017
Merged

Switch to minikube/localkube#123
mbohlool merged 1 commit into
kubernetes-client:masterfrom
dims:try-localkube-for-e2e

Conversation

@dims

@dims dims commented Feb 9, 2017

Copy link
Copy Markdown
Collaborator
  • Drop the old Kubernetes on docker containers method as it
    did not have a SSL enabled port
  • Use localkube component from minikube instead. This enables
    us to drop the hitch TLS proxy as well.
  • E2E tests should be easy to run locally and pick up configuration
    from ~/.kube/config
  • Consolidate the urls in one spot (base.py), also consolidate the
    SkipTest in one spot.
  • For local testing, just run minikube and run the py27 or py34 tox
    target, that should run all the tests including the e2e tests.
  • Fix the connect_post_namespaced_pod_exec and add a e2e test for it

Fixes #122

* Drop the old Kubernetes on docker containers method as it
  did not have a SSL enabled port
* Use localkube component from minikube instead. This enables
  us to drop the hitch TLS proxy as well.
* E2E tests should be easy to run locally and pick up configuration
  from ~/.kube/config
* Consolidate the urls in one spot (base.py), also consolidate the
  SkipTest in one spot.
* For local testing, just run minikube and run the py27 or py34 tox
  target, that should run all the tests including the e2e tests.
* Fix the connect_post_namespaced_pod_exec and add a e2e test for it

Fixes kubernetes-client#122
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 9, 2017
@dims dims mentioned this pull request Feb 9, 2017
@mbohlool

mbohlool commented Feb 9, 2017

Copy link
Copy Markdown
Contributor

Nicely done. Thanks @dims

@mbohlool mbohlool self-assigned this Feb 9, 2017
@mbohlool mbohlool added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2017
@mbohlool
mbohlool merged commit 1635150 into kubernetes-client:master Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants