Skip to content

Add initial version of generating script and the generated client#1

Merged
mbohlool merged 2 commits into
masterfrom
o1
Nov 2, 2016
Merged

Add initial version of generating script and the generated client#1
mbohlool merged 2 commits into
masterfrom
o1

Conversation

@mbohlool

@mbohlool mbohlool commented Oct 31, 2016

Copy link
Copy Markdown
Contributor

The first pull request for client-python is adding the generation script and a generated client with minimum modification.

smarterclayton
smarterclayton reviewed Oct 31, 2016
View reviewed changes
Comment thread scripts/generate.sh Outdated

@smarterclayton smarterclayton Oct 31, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do they offer a maven task for this?

@mbohlool mbohlool Oct 31, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look like they do: https://github.com/swagger-api/swagger-codegen/blob/master/modules/swagger-codegen-maven-plugin/README.md

Only issue here is I am using an unofficial jar file right now in my bin folder that has my latest fix to codegen If I can specify this in the maven plugin (to use the latest version from repo), I will change this to maven.

@mbohlool mbohlool Nov 1, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@mbohlool

mbohlool commented Nov 1, 2016

Copy link
Copy Markdown
Contributor Author

PTAL

@mbohlool
mbohlool force-pushed the o1 branch 5 times, most recently from 7dbfd45 to 8ff6d11 Compare November 1, 2016 09:34
caesarxuchao
caesarxuchao reviewed Nov 1, 2016
View reviewed changes
Comment thread scripts/generate.sh Outdated

@caesarxuchao caesarxuchao Nov 1, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put double quotes around in case the variable contains spaces? There are several occurrences later as well.

@mbohlool mbohlool Nov 1, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed them all. Please check again and let me know if I missed anything.

Comment thread scripts/generate.sh Outdated

@caesarxuchao caesarxuchao Nov 1, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line?

@mbohlool mbohlool Nov 1, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mbohlool

mbohlool commented Nov 2, 2016

Copy link
Copy Markdown
Contributor Author

Friendly ping!

@mbohlool
mbohlool force-pushed the o1 branch 2 times, most recently from 2ef02b9 to 3e54dbc Compare November 2, 2016 20:38
@caesarxuchao

caesarxuchao commented Nov 2, 2016 •
edited
Loading

Copy link
Copy Markdown

The script lgtm. I'll apply the label and we can improve the generated client in future iteration. @mbohlool feel free to self merge.

@mbohlool mbohlool added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2016
@mbohlool
mbohlool merged commit d67df30 into master Nov 2, 2016
@mbohlool
mbohlool deleted the o1 branch November 16, 2016 00:55
@mbohlool mbohlool added this to the v1.0 milestone Nov 17, 2016
@klarose klarose mentioned this pull request Aug 23, 2018
Closed
@klarose klarose mentioned this pull request Nov 28, 2018
Closed
@yliaog yliaog mentioned this pull request Jul 16, 2019
Closed
yliaog pushed a commit to yliaog/client-python that referenced this pull request Jan 8, 2022
@mbohlool
Merge pull request kubernetes-client#1 from mbohlool/master
bf62a92 
Copy over base folder of python-client
@jtwb jtwb mentioned this pull request Jul 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@smarterclayton smarterclayton smarterclayton left review comments
@caesarxuchao caesarxuchao caesarxuchao left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@smarterclayton smarterclayton

@caesarxuchao caesarxuchao

Labels

lgtm "Looks good to me", indicates that a PR is ready to be merged.

Projects

None yet

Milestone

v1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mbohlool @caesarxuchao @smarterclayton