Skip to content

Generate a jar with dependencies and build a Dockerfile for it.#76

Merged
mbohlool merged 1 commit into
kubernetes-client:masterfrom
brendandburns:dockerfile
Sep 23, 2017
Merged

Generate a jar with dependencies and build a Dockerfile for it.#76
mbohlool merged 1 commit into
kubernetes-client:masterfrom
brendandburns:dockerfile

Conversation

@brendandburns

Copy link
Copy Markdown
Contributor

@lwander @mbohlool

Useful for testing in clusters.

@mbohlool

Copy link
Copy Markdown
Contributor

lgtm

@mbohlool mbohlool merged commit 0f9a617 into kubernetes-client:master Sep 23, 2017
@rvowles

rvowles commented Sep 24, 2017

Copy link
Copy Markdown

Problems:

  • Your "jar with dependencies" also contains all of the test dependencies, so junit & hamcrest is there
  • Everything is flattened into one namespace, so you are getting unpredictable behaviour when some files may be the same (e.g. manifests, configuration files, service loaders, etc).

It would have been better to use spring boot loader (which has nothing to do with spring boot thankfully). It is just as easy to configure and avoids all of these problems:

https://docs.spring.io/spring-boot/docs/current/maven-plugin/usage.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants