Delete non-Maven build scripts#521
Merged
Merged
Conversation
Contributor
|
Fine with me, but please add to https://github.com/kubernetes-client/java/blob/master/kubernetes/.swagger-codegen-ignore or else we'll just regenerate them next time we codegen. Thanks! |
Contributor
Author
Done, though I am not sure how to test this. (Not familiar with Swagger.) |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, jglick The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When this project was created, in #1, it included a
kubernetes/build.gradleand related files. It also included a Mavenkubernetes/pom.xml, oh and a Scala-stylekubernetes/build.sbtfor good measure. The initialkubernetes/.travis.ymlsuggests that this was all just dumped here by Swagger, not deliberate. Later in #5, #73, etc. the structure was rearranged, all assuming a Maven build—as does the current (top-level).travis.ymlandREADME.md. In fact the current structure has a root POM and declares thekubernetessubdirectory as amodule, which implies that it is to be built via Maven. Thebuild.gradleis clearly out of date—for example, it does not reflect #453.My practical interest in this is that the NetBeans IDE currently prefers
build.gradletopom.xmlwhen both are present in a directory, so thekubernetessubdirectory gets opened as a Gradle project and it is a mess. If build scripts and related metadata are not actually current and usable, they are better deleted to avoid confusion.