fix for exec command encoding issue#258
Merged
brendandburns merged 3 commits intoMay 5, 2018
Merged
Conversation
| boolean stdin, | ||
| boolean tty) { | ||
| String namespace, String name, String[] command, String container, boolean stdin, boolean tty) | ||
| throws UnsupportedEncodingException { |
Contributor
There was a problem hiding this comment.
Hrm, I feel like populating this forward is probably not right. The encoder is extremely unlikely to throw this since UTF-8 is supported everywhere (and it better be, or HTTP won't work right...)
So I would just try/catch and then throw RuntimeException or some other sort of exception that doesn't have to be caught.
| for (int i = 0; i < command.length; i++) { | ||
| try { | ||
| command[i] = URLEncoder.encode(command[i], "UTF-8"); | ||
| } catch (Exception ex) { |
Contributor
There was a problem hiding this comment.
Don't catch Exception catch UnknownFormatException
Contributor
There was a problem hiding this comment.
oops I meant UnsupportedEncodingException
brendandburns
requested changes
May 3, 2018
| for (int i = 0; i < command.length; i++) { | ||
| try { | ||
| command[i] = URLEncoder.encode(command[i], "UTF-8"); | ||
| } catch (Exception ex) { |
Contributor
There was a problem hiding this comment.
oops I meant UnsupportedEncodingException
Contributor
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes issue #257 by performing URLEncoder.encode on list of commands