Skip to content

Chore: Adding admissionreview to the submodule list#1776

Merged
k8s-ci-robot merged 2 commits into
kubernetes-client:masterfrom
yue9944882:chore/root-pom-admission-review-submodule
Jul 7, 2021
Merged

Chore: Adding admissionreview to the submodule list#1776
k8s-ci-robot merged 2 commits into
kubernetes-client:masterfrom
yue9944882:chore/root-pom-admission-review-submodule

Conversation

@yue9944882
Copy link
Copy Markdown
Member

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 6, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 6, 2021
Comment thread client-java-contrib/admissionreview/pom.xml
@brendandburns
Copy link
Copy Markdown
Contributor

This looks good (thanks) but we need to retain the dependencies, I think.

@yue9944882 yue9944882 force-pushed the chore/root-pom-admission-review-submodule branch from c47f8cd to 4336e6c Compare July 7, 2021 10:51
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 7, 2021
@brendandburns
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,yue9944882]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2d6e823 into kubernetes-client:master Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants