Add AdmissionReview models.#1774
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yue9944882
left a comment
There was a problem hiding this comment.
(1) can we add a <parent/> section in the new module and also adding it to the <modules/> list in the root pom on the other hand?
(2) ideally i think we should clarify the version of the local swagger spec, i.e. from which version of kube-apiserver it is downloaded? e.g. admission-swagger-v1.20.4.json?
| </developer> | ||
| </developers> | ||
|
|
||
| <build> |
There was a problem hiding this comment.
the whole <build>..</build> section can be removed, is it?
| </license> | ||
| </licenses> | ||
|
|
||
| <developers> |
There was a problem hiding this comment.
can we remove the <developer> section? and the <licenses> section above as well?
| <groupId>io.kubernetes</groupId> | ||
| <artifactId>client-java</artifactId> | ||
| <packaging>jar</packaging> | ||
| <name>client-java</name> |
There was a problem hiding this comment.
<name>client-java-admission-review</name>
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
| <groupId>io.kubernetes</groupId> | ||
| <artifactId>client-java</artifactId> |
There was a problem hiding this comment.
<artifactId>client-java-admission-review</artifactId>
| </profiles> | ||
|
|
||
| <dependencies> | ||
| <dependency> |
There was a problem hiding this comment.
i think over half of the following dependencies can be removed by declaring the root pom as <parent/>, but we can sanitize this in a followup.
There was a problem hiding this comment.
cleaned this up.
|
Apologies, I just committed the generated pom.xml without cleaning it up. Addressed all comments, please take another look. |
Ref #1772
cc @yue9944882