Skip to content

Tidy up SpringBootTests#1688

Merged
k8s-ci-robot merged 1 commit into
kubernetes-client:masterfrom
dsyer:tidy-tests
May 10, 2021
Merged

Tidy up SpringBootTests#1688
k8s-ci-robot merged 1 commit into
kubernetes-client:masterfrom
dsyer:tidy-tests

Conversation

@dsyer

@dsyer dsyer commented May 6, 2021 •
edited
Loading

Copy link
Copy Markdown

Tests with [at]SpringBootTest automatically look for configuration files
nested inside them, so you don't need to explicitly enumerate them.

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 6, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 6, 2021
yue9944882
yue9944882 reviewed May 8, 2021
View reviewed changes

@yue9944882 yue9944882 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

can you amend the commit message so the bot can detach the label?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2021
@dsyer

dsyer commented May 9, 2021

Copy link
Copy Markdown
Author

can you amend the commit message so the bot can detach the label?

I don't think the commit message needed to be amended. Is the bot completely insane?

Tidy up SpringBootTests
affe11d 
Tests with [at]SpringBootTest automatically look for configuration files
nested inside them, so you don't need to explicitly enumerate them.

Signed-off-by: Dave Syer <dsyer@vmware.com>
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels May 9, 2021
@dsyer

dsyer commented May 9, 2021

Copy link
Copy Markdown
Author

Yes, the bot is completely insane. Please fix it.

@yue9944882

yue9944882 commented May 10, 2021

Copy link
Copy Markdown
Member

Yes, the bot is completely insane. Please fix it.

we're forbidding @+<Github Users> in the commit message to avoid spamming references which can be exponentially increasing when users fork the project or even fork the fork..

yue9944882
yue9944882 reviewed May 10, 2021
View reviewed changes

@yue9944882 yue9944882 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2021
@k8s-ci-robot

k8s-ci-robot commented May 10, 2021

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsyer, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit c004c1f into kubernetes-client:master May 10, 2021
@dsyer dsyer deleted the tidy-tests branch May 10, 2021 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yue9944882 yue9944882 yue9944882 left review comments
@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@yue9944882 yue9944882

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dsyer @yue9944882 @k8s-ci-robot