Skip to content

Flake: Relaxing FromConfigMap tests timeout to 2s#1667

Merged
k8s-ci-robot merged 1 commit into
kubernetes-client:masterfrom
yue9944882:flake/relax-from-configmap-timeout
Apr 24, 2021
Merged

Flake: Relaxing FromConfigMap tests timeout to 2s#1667
k8s-ci-robot merged 1 commit into
kubernetes-client:masterfrom
yue9944882:flake/relax-from-configmap-timeout

Conversation

@yue9944882
Copy link
Copy Markdown
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 23, 2021
@yue9944882
Copy link
Copy Markdown
Member Author

ref: #1665

@yue9944882 yue9944882 force-pushed the flake/relax-from-configmap-timeout branch from 98a59a2 to 245144f Compare April 23, 2021 08:15
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 23, 2021
@brendandburns
Copy link
Copy Markdown
Contributor

I'd rather see something deterministic rather than just a longer sleep, but this will fix things somewhat so lgtm

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,yue9944882]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6c28218 into kubernetes-client:master Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants