Skip to content

Make sundr codegen optional so it only applies to the k8s API code#1423

Merged
k8s-ci-robot merged 1 commit into
kubernetes-client:masterfrom
dsyer:optional
Dec 9, 2020
Merged

Make sundr codegen optional so it only applies to the k8s API code#1423
k8s-ci-robot merged 1 commit into
kubernetes-client:masterfrom
dsyer:optional

Conversation

@dsyer

@dsyer dsyer commented Dec 8, 2020

Copy link
Copy Markdown

Fixes #1422

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 8, 2020
@dsyer dsyer force-pushed the optional branch 3 times, most recently from 42e2969 to e2db36f Compare December 8, 2020 09:24
Signed-off-by: Dave Syer <dsyer@vmware.com>

@yue9944882 yue9944882 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2020
@brendandburns

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, dsyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit ffb7dee into kubernetes-client:master Dec 9, 2020
@dsyer dsyer deleted the optional branch December 9, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dependecy hygiene: sundr-codegen should be optional

4 participants