Skip to content

Amend Compatibility table to document n-2 version guarantees.#1184

Merged
k8s-ci-robot merged 1 commit into
kubernetes-client:masterfrom
Capstan:compatibility-tweak
Sep 2, 2020
Merged

Amend Compatibility table to document n-2 version guarantees.#1184
k8s-ci-robot merged 1 commit into
kubernetes-client:masterfrom
Capstan:compatibility-tweak

Conversation

@Capstan
Copy link
Copy Markdown
Contributor

@Capstan Capstan commented Aug 23, 2020

I don't have a link at the moment, but IIRC, kubernetes masters only promise backwards compatibility of two versions of the API client, so running a version older than that may run into potholes of broken behavior as the master no longer supports a deprecated/removed API.

/cc @lavalamp

@k8s-ci-robot k8s-ci-robot requested a review from lavalamp August 23, 2020 15:16
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 23, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @Capstan!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 23, 2020
@Capstan
Copy link
Copy Markdown
Contributor Author

Capstan commented Aug 23, 2020

/assign @brendandburns

Copy link
Copy Markdown
Member

@yue9944882 yue9944882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe you're referring to this page where it says:

The Kubernetes project maintains release branches for the most recent three minor releases (1.18, 1.17, 1.16).

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2020
@lavalamp
Copy link
Copy Markdown

The clients should really continue to work for longer than that. It's really feature deprecation that happens.

Our existing go client libraries mix in stuff that doesn't stop being correct (machinery) with stuff that does change over time (the api types), which is unfortunate.

Comment thread README.md
Kubernetes cluster, but everything they have in common will work.
* `-` The Kubernetes cluster has features the java-client library can't use
(additional API objects, etc).
* `x` The Kubernetes cluster has no guarantees to support the API client of
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to "is not tested" rather than "may simply break"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, it's more than just "not tested". If an API version is deprecated, and two versions later it is removed, then that functionality will simply not work.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to keep clarity while softening the statement. PTAL.

@brendandburns
Copy link
Copy Markdown
Contributor

I'm not necessarily opposed to this, but our APIs have really rarely changed, I'd like the language to be a little weaker so that we don't scare people away.

@brendandburns
Copy link
Copy Markdown
Contributor

@Capstan friendly ping, thanks!

@Capstan Capstan force-pushed the compatibility-tweak branch from 770632f to 3ba603c Compare September 2, 2020 15:44
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 2, 2020
@brendandburns
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, Capstan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2020
@brendandburns
Copy link
Copy Markdown
Contributor

Thanks!

@k8s-ci-robot k8s-ci-robot merged commit 17a2012 into kubernetes-client:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants