Provide standard method to cleanup schedulers#1115
Conversation
Once created, `LeaderElector` will never release thread pools. In some environments this prevents JVM shutdown and causes memory leak.
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Welcome @nurkiewicz! |
|
/assign @yue9944882 |
yue9944882
left a comment
There was a problem hiding this comment.
thanks! the diff is neat
/lgtm
|
/approve Should we update the examples to use the AutoClose functionality? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, nurkiewicz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Once created,
LeaderElectorwill never release thread pools. In some environments this prevents JVM shutdown and causes memory leak.