Switiching to apps/v1 deployment api in the examples#1084
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -102,17 +101,17 @@ public static void main(String[] args) throws IOException { | |||
| // apply-yaml a deployment, server side apply is alpha in kubernetes v1.14, | |||
| // You need to actively enable the Server Side Apply alpha feature | |||
| // https://kubernetes.io/docs/reference/using-api/api-concepts/#server-side-apply | |||
There was a problem hiding this comment.
Is this comment is still needed in the lite of 1.18?
There was a problem hiding this comment.
good catch, i updated the comment to clarify that server-side-apply is enabled by default after v1.16
| // https://kubernetes.io/docs/reference/using-api/api-concepts/#server-side-apply | ||
| ExtensionsV1beta1Deployment deploy4 = | ||
| V1Deployment deploy4 = | ||
| PatchUtils.patch( |
There was a problem hiding this comment.
@yue9944882 I run your version of example and for yaml apply I received an error:
{"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"failed to create typed patch object: .spec.template.spec.containers[name="hello-node"].ports: element 0: associative list with keys has an element that omits key field "protocol"","code":500}
There was a problem hiding this comment.
can you retry on my latest update? i just re'produced the error on a v1.18 cluster and fixed it.
7e0c10a to
215fbb2
Compare
|
/lgtm Thanks! |
Fixes: #1075