This repository was archived by the owner on Aug 15, 2022. It is now read-only.
Configure with inheriting options flags - #11466
Merged
Merged
Conversation
cihangir
reviewed
Oct 20, 2017
| level1a : | ||
| level2a : 'test-level2a-value' | ||
| level2b : | ||
| level3a : 'test-level3a-value' |
Contributor
There was a problem hiding this comment.
Could you make this level3b with that way we can ensure that we preserve the existing ones while adding a new property in "level 3" items.
cihangir
suggested changes
Oct 20, 2017
cihangir
left a comment
Contributor
There was a problem hiding this comment.
just one small test case
szkl
approved these changes
Oct 24, 2017
mertaytore
force-pushed
the
inherit-options
branch
from
October 25, 2017 11:25
95d7bae to
3852d80
Compare
cihangir
approved these changes
Oct 25, 2017
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Options flags can now change default values of credentials values for dev environment.
Tests and necessary additions to circleci are also included.