Skip to content

Thread in Metric.Spec.StableWindow as the young pod cutoff time. - #6649

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
vagababov:20200127-moar-scraper-changes
Jan 28, 2020
Merged

knative-prow-robot merged 1 commit into
knative:masterfrom
vagababov:20200127-moar-scraper-changes

Conversation

@vagababov

Copy link
Copy Markdown
Contributor

Use the stable window as a decision marker for whether the pod is young or not.
It makes sense in general, though I am less sure for very large values of window.
Anyhow, we'll just pick young pods otherwise.

/lint
/assign @markusthoemmes

Use the stable window as a decision marker for whether the pod is young or not.
It makes sense in general, though I am less sure for very large values of window.
Anyhow, we'll just pick young pods otherwise.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 28, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 28, 2020

@knative-prow-robot knative-prow-robot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagababov: 0 warnings.

Details

In response to this:

Use the stable window as a decision marker for whether the pod is young or not.
It makes sense in general, though I am less sure for very large values of window.
Anyhow, we'll just pick young pods otherwise.

/lint
/assign @markusthoemmes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2020
@knative-metrics-robot

Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/autoscaler/stats_scraper.go 91.3% 91.4% 0.1

@markusthoemmes markusthoemmes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2020
@knative-prow-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot
knative-prow-robot merged commit fca816e into knative:master Jan 28, 2020
@vagababov
vagababov deleted the 20200127-moar-scraper-changes branch June 23, 2020 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/autoscale cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants