Convert assertions to if+raise#18
Merged
Merged
Conversation
Owner
|
Oh I just saw this. Nice work! Thanks @Depaulicious |
kkroening
added a commit
that referenced
this pull request
Jul 5, 2017
kkroening
added a commit
that referenced
this pull request
Jul 6, 2017
kkroening
added a commit
that referenced
this pull request
Jul 6, 2017
kkroening
added a commit
that referenced
this pull request
Jul 6, 2017
kkroening
added a commit
that referenced
this pull request
Jul 6, 2017
kkroening
added a commit
that referenced
this pull request
Jul 6, 2017
kkroening
added a commit
that referenced
this pull request
Jul 6, 2017
kkroening
added a commit
that referenced
this pull request
Jul 12, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assertions are ignored if the interpreter is run with the
-O(optimize).I converted all assertions outside of tests to normal exceptions.
Please review the type of the exceptions (maybe we could define some new, module-specific ones), I tried to use the most meaningful ones (basically all
ValueErrorand oneRuntimeError).