Skip to content

Commit 06abe4b

Browse files
committed
view=expanded just for Thread resource
1 parent 419bc94 commit 06abe4b

3 files changed

Lines changed: 13 additions & 7 deletions

File tree

nylas/client/client.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,7 @@ def accounts(self):
295295

296296
@property
297297
def threads(self):
298-
return RestfulModelCollection(Thread, self)
298+
return RestfulModelCollection(Thread, self, view="expanded")
299299

300300
@property
301301
def folders(self):
@@ -363,7 +363,6 @@ def _get_resources(self, cls, extra=None, **filters):
363363
converted_filters = convert_datetimes_to_timestamps(
364364
filters, cls.datetime_filter_attrs
365365
)
366-
converted_filters["view"] = "expanded"
367366
url = str(URLObject(url).add_query_params(converted_filters.items()))
368367
response = self._get_http_session(cls.api_root).get(url)
369368
results = _validate(response).json()
@@ -387,7 +386,6 @@ def _get_resource_raw(
387386
converted_filters = convert_datetimes_to_timestamps(
388387
filters, cls.datetime_filter_attrs
389388
)
390-
converted_filters["view"] = "expanded"
391389
url = str(URLObject(url).add_query_params(converted_filters.items()))
392390
response = self._get_http_session(cls.api_root).get(
393391
url, headers=headers, stream=stream

nylas/client/restful_model_collection.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,10 @@ def where(self, filter=None, **filters):
8383
pairs = convert_metadata_pairs_to_array(filters["metadata_pair"])
8484
filters["metadata_pair"] = pairs
8585

86-
collection = copy(self)
87-
collection.filters = filters
88-
return collection
86+
for k, v in filters.items():
87+
self.filters[k] = v
88+
89+
return copy(self)
8990

9091
def get(self, id):
9192
return self._get_model(id)
@@ -127,7 +128,6 @@ def __getitem__(self, key):
127128
return self._get_model_collection(key, 1)[0]
128129

129130
# Private functions
130-
131131
def _get_model_collection(self, offset=0, limit=CHUNK_SIZE):
132132
filters = copy(self.filters)
133133
filters["offset"] = offset

nylas/client/restful_models.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -341,6 +341,14 @@ class Thread(NylasAPIObject):
341341
def __init__(self, api):
342342
NylasAPIObject.__init__(self, Thread, api)
343343

344+
@property
345+
def messages(self):
346+
return self.child_collection(Message, thread_id=self.id)
347+
348+
@property
349+
def drafts(self):
350+
return self.child_collection(Draft, thread_id=self.id)
351+
344352
@property
345353
def folders(self):
346354
if self._folders:

0 commit comments

Comments
 (0)