Skip to content

Overdue deterministic fix#1819

Draft
pierre wants to merge 4 commits intomasterfrom
overdue-deterministic-fix
Draft

Overdue deterministic fix#1819
pierre wants to merge 4 commits intomasterfrom
overdue-deterministic-fix

Conversation

@pierre
Copy link
Copy Markdown
Member

@pierre pierre commented Dec 12, 2022

See discussion here.

pierre added 4 commits April 6, 2017 23:41
When running the OverdueStateApplicator logic, a lot of actions
can be triggered on different sub-systems:

* Cancellation of subscriptions
* Transition into / out of AUTO_INVOICE_OFF
* New blocking states set

These actions potentially send events on the bus that invoice will
react to, and the timing of these actions can make the resulting
invoice(s) non-deterministic.

This patch:

* Delays sending AUTO_INVOICE_OFF events until after the new blocking states are set
* Sets and unsets AUTO_INVOICE_OFF around the whole overdue logic when cancelling subscriptions

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
Make sure that in case of rollbacks (potentially wrong) mappings are not cached.

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants