fix(linux): fix memory problem 🍒 🏠#15828
Merged
ermshiperete merged 1 commit intostable-18.0from Apr 9, 2026
Merged
Conversation
This fixes a problem identified by devin.ai: Because of the operator precedence the previous code caused `memmove` to read `sizeof(commit_queue_item) - 1` bytes past the end of `commit_queue`. With this change `memmove` now reads the intended `MAX_QUEUE_SIZE - 1` `commit_queue_items`. Cherry-pick-of: #15823 Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
mcdurdin
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a problem identified by devin.ai: Because of the operator precedence the previous code caused
memmoveto readsizeof(commit_queue_item) - 1bytes past the end ofcommit_queue. With this changememmovenow reads the intendedMAX_QUEUE_SIZE - 1commit_queue_items.Cherry-pick-of: #15823
Test-bot: skip