chore(developer): enable skipped test for disp key cap constants 🔱#15822
Merged
mcdurdin merged 7 commits intoepic/embed-osk-in-kmxfrom Apr 16, 2026
Merged
Conversation
This comes out of a design philosophy review on what we include when we embed OSK data into KMX. We will now avoid embedding font name into the OSK (and hence .kmx) altogether, and leave that metadata to the packaging data. Reasons: 1. The font information is specified in the .kps, so we have to do a patchup on the .kmx during packaging if we want to embed the info into the OSK. 2. The referenced font must be supplied separately anyway (via .kmp, @font-face, or system supplied, etc), so including the font facename in the keyboard is not really all that helpful. 3. Philosophically, the font is really a presentation level factor (aside from displaymap considerations). Keeping it together with future theming and styling choices, rather than the key layout data, seems appropriate. 4. This makes fewer places where font data is referenced -- in fact, to just one place: in the .kps/.kmp for LDML keyboards, which is great. This also simplifies some aspects of the embed-osk-in-kmx work, removing the need to patch the .kmx after the build, and eliminates the smelly kmx-plus-osk-token.ts file. A corresponding change has been made to the design document referenced in #14857. Test-bot: skip
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
Refactor the `getModifierState` and `getStateFromLayer` functions into a cleaner `modifierStringToState` function, and move from web into common. Marks existing functions as deprecated but does not update usage at this time.
Add mappings for key to vkey + mod for .kvk and .keyman-touch-layout, and clarify the key identifiers for .keyman-touch-layout within KMX+ format. Update unit test fixture khmer_angkor.keyman_touch_layout to remove dependency on .kmn (T_xxxx_yyyy -> U_xxxx_yyyy), as the relevant VKDictionary will not be present, because the corresponding .kmn is not compiled for the unit tests where the fixture is used. Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
ermshiperete
approved these changes
Apr 9, 2026
2399324 to
401c0db
Compare
…ed-osk/enable-constants-test
Base automatically changed from
feat/developer/embed-osk/kmap
to
epic/embed-osk-in-kmx
April 16, 2026 20:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-bot: skip