Skip to content

fix bugs, add descriptions, and add tests#486

Merged
keon merged 6 commits into
keon:masterfrom
JKLiang9714:master
Mar 8, 2019
Merged

fix bugs, add descriptions, and add tests#486
keon merged 6 commits into
keon:masterfrom
JKLiang9714:master

Conversation

@JKLiang9714
Copy link
Copy Markdown
Contributor

  1. Fixed some bugs in "longest_non_repeat.py"
  2. Added description for the algorithm in "anagram.py"
  3. Updated description for the algorithm in "generate_abbreviations.py", "letter_combination.py"
  4. Added tests for the algorithm in "test_array.py", "test_backtrack.py"

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 871

  • 70 of 73 (95.89%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+1.2%) to 66.206%

Changes Missing Coverage Covered Lines Changed/Added Lines %
algorithms/arrays/longest_non_repeat.py 12 15 80.0%
Files with Coverage Reduction New Missed Lines %
algorithms/sort/top_sort.py 2 90.38%
Totals Coverage Status
Change from base Build 870: 1.2%
Covered Lines: 4643
Relevant Lines: 7013

💛 - Coveralls

@keon
Copy link
Copy Markdown
Owner

keon commented Mar 8, 2019

awesome man

@keon keon merged commit f438cd3 into keon:master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants