add atbash, crout, hosoya triangle algorithms#470
Merged
Conversation
keon
reviewed
Jan 18, 2019
Owner
keon
left a comment
There was a problem hiding this comment.
thanks for your contribution!
I added some minor comments on naming convention.
I'd be nice to have some unit tests as well.
|
|
||
|
|
||
|
|
||
| def Hosoya(n, m): |
| else: | ||
| return 0 | ||
|
|
||
| def printHosoya(n): |
Contributor
Author
|
Ok, I'll work on the tests throughout the weekend, I should be able to include them by sunday. |
Contributor
Author
|
I've added the unittests, updated non-english readmes, made some descriptions better and changed crout to always return floats. |
Owner
|
@Notheryne Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Put an
Xinside the[ ]to denote check mark[X].)If creating a new file :
if done some changes :
other