Skip to content

Harshad number C implementation#480

Merged
patrickyevsukov merged 3 commits into
kennyledet:masterfrom
jb1717:master
Sep 8, 2015
Merged

Harshad number C implementation#480
patrickyevsukov merged 3 commits into
kennyledet:masterfrom
jb1717:master

Conversation

@jb1717
Copy link
Copy Markdown
Contributor

@jb1717 jb1717 commented Aug 26, 2015

Implementation of Harshad number with the main function for testing.

@patrickyevsukov
Copy link
Copy Markdown
Collaborator

Thanks for the submission!

Could you please amend it to follow the unit testing conventions mentioned in the README ?

@jb1717
Copy link
Copy Markdown
Contributor Author

jb1717 commented Sep 5, 2015

I added some tests and descriptions !

@patrickyevsukov
Copy link
Copy Markdown
Collaborator

Thanks for amending your submission!

Before I go ahead and merge it, please amend your test to check the veracity of your algorithm's output; currently it seems to be only printing the output of your algorithm - leaving it up to the user to confirm the correctness by visual inspection. I would ask that it check the output (with assert statements) against an array of expected outputs.

@patrickyevsukov
Copy link
Copy Markdown
Collaborator

@jb1717
Copy link
Copy Markdown
Contributor Author

jb1717 commented Sep 7, 2015

Thank you, I updated a little bit my test file to assert when the output is wrong.

Hope all is good now :p

@patrickyevsukov
Copy link
Copy Markdown
Collaborator

Perfect! Thanks for the updates 😄

patrickyevsukov added a commit that referenced this pull request Sep 8, 2015
Harshad number C implementation
@patrickyevsukov patrickyevsukov merged commit 193947f into kennyledet:master Sep 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants