feat/rxjava_2 Retrofit related examples update to RxJava2#84
Merged
kaushikgopal merged 7 commits intoNov 27, 2016
Conversation
Contributor
Author
|
@kaushikgopal rebasing causes your commits to show up here. Any idea how to prevent this? I'm not too exprienced with PR's (only used "regular" git so far) |
Owner
|
@marcinkunert - don't worry about it. i'll keep track when merging. since all of this is getting clubbed together in a single PR, that would eventually get merged to master, i'm not terribly concerned about it. typically, i perform merges vs rebase's and that "keeps" the history, but that the history log tends to look nasty anyway ¯_(ツ)_/¯. these PRs are granular enough where i don't think it should matter. 👍 thanks for the awesome work on all these |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated Retrofit related examples to RxJava2
Part of #83