fix: dereference symlinks when copying git skill subpaths#1649
Merged
EItanya merged 6 commits intoApr 21, 2026
Conversation
f796457 to
740c126
Compare
Signed-off-by: Sam Skelton <samuellskelton@gmail.com>
740c126 to
75490f7
Compare
Contributor
|
@EItanya bumping this PR as it would help us tremendously with our current skills setup. follow symlinks allow us to maintain single kb folder for skills that are for different agents e.g claude code vs agents in kagent |
EItanya
previously approved these changes
Apr 17, 2026
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
…mlink-copy-signoff Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> # Conflicts: # go/core/internal/controller/translator/agent/testdata/outputs/agent_with_git_skills.json
f977de2 to
2088700
Compare
EItanya
approved these changes
Apr 20, 2026
Huimintai
pushed a commit
to Huimintai/kagent
that referenced
this pull request
Apr 21, 2026
…#1649) When a git skill uses a path, the init script copies the selected subdirectory and then removes the original clone root. With cp -a, symlinks inside that subdirectory are preserved as symlinks, so repo-internal links can break once the clone root is deleted. This switches that copy step to cp -rL so symlink targets are materialized before the source repo is removed. - GOCACHE=/tmp/go-build GOMODCACHE=/tmp/go-mod-cache go test ./core/internal/controller/translator/agent/... --------- Signed-off-by: Sam Skelton <samuellskelton@gmail.com> Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Co-authored-by: Eitan Yarmush <eitan.yarmush@solo.io> fix: apply ruff formatting to SAP AI Core Python files Signed-off-by: Huimin Tai <huimin.tai@sap.com> fix: modernize concurrent test to use range-over-int and WaitGroup.Go Signed-off-by: Huimin Tai <huimin.tai@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a git skill uses a path, the init script copies the selected subdirectory and then removes the original clone root. With cp -a, symlinks inside that subdirectory are preserved as symlinks, so repo-internal links can break once the clone root is deleted.
This switches that copy step to cp -rL so symlink targets are materialized before the source repo is removed.
Verification