Conversation
|
It seems to work only with this ugly workaround for now: import sys
import types
sys.modules['tornado'] = types.ModuleType('tornadofake')Tracking this in ipympl directly: matplotlib/ipympl#334 |
It would be totally fine to have that in the examples for now. Or maybe we should even bake that in https://github.com/jtpio/jupyterlite/blob/main/packages/pyolite-kernel/py/pyolite/pyolite/__init__.py directly? |
|
Yes! I can do that :) |
|
Not to pick on this PR (which is raaaad), but could we, to the extent possible, be more intentional about some of the imports hacks so that these things run under try:
import pyolite
# do hacky things
except ImportError:
passIt's also worth adding a |
Yeah! I guess all the |
Maybe, at the expense of making the code less readable?
Maybe we could track this in a separate issue. For now the example notebooks are really meant to be used in JupyterLite so they could probably stay as they are? |
|
@martinRenou should we go ahead and merge this PR? I guess we can always go back to it later once matplotlib/matplotlib#20591 is fixed |
|
If there is no other blocker, yes :) |
|
I've added a screencast to the top comment for reference. |
ipympl.mp4