Repository navigation
Create separate file systems for jars during classpath scanning - #6143
Open
marcphilipp wants to merge 6 commits into
Open
marcphilipp wants to merge 6 commits into
marcphilipp wants to merge 6 commits into
Conversation
Instead, resolve `URI` to `Path` using `Path.of(URI)` first.
mpkorstanje
reviewed
Oct 9, 2026
mpkorstanje
reviewed
Oct 9, 2026
✅ All tests passed ✅🏷️ Commit: 2dd6d02 Learn more about TestLens at testlens.app/docs. |
mpkorstanje
self-requested a review
October 9, 2026 16:00
mpkorstanje
reviewed
Oct 9, 2026
| var path1 = CloseablePath.create(jarUri(original)); | ||
| paths.add(path1); | ||
| var path2 = CloseablePath.create(uri); | ||
| var path2 = CloseablePath.create(jarUri(original)); |
Member
There was a problem hiding this comment.
Does this test need two closable paths? We've already established they're independent in createsSeparateFileSystemsForJarFilesOnNonDefaultFileSystem
mpkorstanje
reviewed
Oct 9, 2026
| paths.add(path2); | ||
|
|
||
| assertThrows(FileSystemNotFoundException.class, () -> FileSystems.getFileSystem(jarUri(original)), | ||
| "Uses separate file systems"); |
Member
There was a problem hiding this comment.
This is also established in createsSeparateFileSystemsForJarFilesOnNonDefaultFileSystem
mpkorstanje
approved these changes
Oct 9, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileSystems.newFileSystem(URI, Map)I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations