fix: accordion expand icon now changes to × on toggle by Tushar8466 · Pull Request #2282 · json-schema-org/website

Tushar8466 · 2026-02-26T07:08:28Z

What kind of change does this PR introduce?
Bug fix

Description
Fixes #2278

When clicking the + icon to expand an accordion card, the icon was not
updating to reflect the expanded state. This was caused by rotate-45
being applied on the parent div instead of the icon span.

Changes Made

Removed rotate-45 from the parent icon container div
Added inline-block and transition-transform duration-200 to the span
Added select-none to prevent text selection on click

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
My changes don't require a change to the documentation

github-actions · 2026-02-26T07:08:41Z

Hi @Tushar8466! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

Copilot

Pull request overview

This PR fixes a visual bug in the accordion component where the expand/collapse icon was rotating incorrectly. The issue was caused by the rotate-45 class being applied to the parent container instead of just the icon itself.

Changes:

Removed rotate-45 class from the icon container div to prevent the entire button from rotating
Added select-none utility class to the icon span to prevent text selection during clicks
Updated submodule references across multiple include files

Reviewed changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
components/Accordion.tsx	Fixed icon rotation by removing `rotate-45` from parent container and added `select-none` to icon span
_includes/draft-02	Updated submodule commit reference
_includes/draft-01	Updated submodule commit reference
_includes/draft-00	Updated submodule commit reference
_includes/dot-github	Updated submodule commit reference
_includes/community	Updated submodule commit reference

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-02-26T07:10:50Z

Hi @Tushar8466! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

github-actions · 2026-02-26T07:17:36Z

Hi @Tushar8466! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

github-actions · 2026-02-26T07:18:24Z

Hi @Tushar8466! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

Tushar8466 · 2026-02-26T07:31:18Z

What kind of change does this PR introduce?

Bug fix

Description

When clicking the + icon to expand an accordion card, the icon was not
updating to reflect the expanded state due to rotate-45 being applied on
the parent div instead of the icon span.

Related issue

Fixes #2278

Checklist

I have read the contributing guidelines
My changes don't require a change to the documentation

github-actions · 2026-02-26T07:53:04Z

Hi @Tushar8466! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

github-actions · 2026-02-26T07:55:09Z

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name	Status	Preview	Last Commit
website	✅ Ready (View Log)	Visit Preview	`d4bfdbc`

codecov · 2026-02-26T07:57:10Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (1a2d4a6) to head (d4bfdbc).
⚠️ Report is 141 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #2282   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines          633       672   +39     
  Branches       196       211   +15     
=========================================
+ Hits           633       672   +39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-02-26T08:16:04Z

Hi @Tushar8466! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

github-actions · 2026-02-26T12:04:17Z

Hi @Tushar8466! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: kind of change description, completed checklist items

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

github-actions · 2026-02-26T12:04:20Z

Hi @Tushar8466! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: kind of change description

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

vtushar06

Thanks @Tushar8466, LGTM🚀,
@Utkarsh-123github PR is ready to merge from my side.

Utkarsh-123github

LGTM🚀
Thanks @Tushar8466 for contribution and @vtushar06 for review.

github-actions · 2026-02-27T04:46:27Z

Congratulations, @Tushar8466 for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema!

Copilot AI review requested due to automatic review settings February 26, 2026 07:08

Tushar8466 requested a review from a team as a code owner February 26, 2026 07:08

github-project-automation Bot added this to PR - Triage Group Feb 26, 2026

github-project-automation Bot moved this to Ready to review in PR - Triage Group Feb 26, 2026

github-actions Bot added the needs-info label Feb 26, 2026

Copilot AI reviewed Feb 26, 2026

View reviewed changes

Tushar8466 changed the title ~~fix: accordion expand icon now rotates to × on toggle~~ fix: accordion expand icon now changes to × on toggle Feb 26, 2026

fix: accordion expand icon now rotates to x on toggle

d4bfdbc

github-actions Bot deployed to Preview February 26, 2026 07:55

View deployment

github-actions Bot removed the needs-info label Feb 26, 2026

vtushar06 self-requested a review February 26, 2026 12:18

vtushar06 approved these changes Feb 26, 2026

View reviewed changes

Utkarsh-123github approved these changes Feb 27, 2026

View reviewed changes

Utkarsh-123github merged commit 4bd72bb into json-schema-org:main Feb 27, 2026
9 of 13 checks passed

github-project-automation Bot moved this from Ready to review to Done in PR - Triage Group Feb 27, 2026

Tushar8466 deleted the fix/accordion-icon-toggle branch February 27, 2026 05:11

Conversation

Tushar8466 commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

github-actions Bot commented Feb 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

github-actions Bot commented Feb 26, 2026

Uh oh!

github-actions Bot commented Feb 26, 2026

Uh oh!

github-actions Bot commented Feb 26, 2026

Uh oh!

Tushar8466 commented Feb 26, 2026

What kind of change does this PR introduce?

Description

Related issue

Checklist

Uh oh!

github-actions Bot commented Feb 26, 2026

Uh oh!

github-actions Bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Uh oh!

codecov Bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Feb 26, 2026

Uh oh!

github-actions Bot commented Feb 26, 2026

Uh oh!

github-actions Bot commented Feb 26, 2026

Uh oh!

vtushar06 left a comment

Choose a reason for hiding this comment

Uh oh!

Utkarsh-123github left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Feb 27, 2026

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Tushar8466 commented Feb 26, 2026 •

edited

Loading

github-actions Bot commented Feb 26, 2026 •

edited

Loading

codecov Bot commented Feb 26, 2026 •

edited

Loading