Skip to content

Update web-platform tests #3203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TimothyGu merged 30 commits into from
Jun 15, 2021
Merged

Update web-platform tests #3203

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
f61347c
Update web-platform-tests
ninevra Jun 9, 2021
5c2bd62
Remove to-run entries that don't match tests
ninevra Jun 9, 2021
7421f2f
Re-add FileReader-multiple-reads as .any
ninevra Jun 9, 2021
420f41f
Re-add filreader_result as .any
ninevra Jun 9, 2021
3cf85eb
Mark cssom-view/getBoundingClientRect-shy as unimplemented
ninevra Jun 9, 2021
2866f0e
Failing AbortSignal.abort() cases moved to new file
ninevra Jun 9, 2021
fb03dd3
Mark new test Event-timestamp-high-resolution.https.html as not imple…
ninevra Jun 9, 2021
31b389d
Mark an execution-timing test as passing
ninevra Jun 9, 2021
4c676ac
Mark two shadow-dom tests as passing
ninevra Jun 9, 2021
d2ab5fc
Mark hr-time/clamped-time* as not implemented
ninevra Jun 9, 2021
5adfda6
Mark some new tests [fail, Unknown]
ninevra Jun 10, 2021
0859f59
Mark failing: delete window[0] shouldn't remove iframes
ninevra Jun 10, 2021
ed3ed1f
Mark failing: TextArea.textContent should be normalized and wrapped
ninevra Jun 10, 2021
f5ab160
Mark xmldecl tests failing with speculation
ninevra Jun 10, 2021
d4ba1c9
Mark some shadowdom tests not implemented
ninevra Jun 10, 2021
d2563cf
Mark new url tests dependent on fetch
ninevra Jun 10, 2021
82baf7e
Mark some websocket tests not implemented
ninevra Jun 10, 2021
b1be5eb
Mark some formdata tests failing
ninevra Jun 10, 2021
7a63fae
Restore note that FormDataEvent is not implemented
ninevra Jun 11, 2021
e2c16cc
Update web-platform-tests again
ninevra Jun 11, 2021
e675ddb
Implement AbortSignal.abort() with circular require().
ninevra Jun 14, 2021
b31e43d
Directly set abortSignal.aborted
ninevra Jun 14, 2021
561aad0
Re-enable formdata tests
ninevra Jun 14, 2021
2b89f74
Normalize textarea form value with lf, not crlf
ninevra Jun 14, 2021
df6f262
Implement textarea wrapping
ninevra Jun 14, 2021
07db989
Don't normalize names in appendAnEntry
ninevra Jun 14, 2021
c198622
Don't normalize values in appendAnEntry
ninevra Jun 14, 2021
2ba7264
Remove unused normalizeToCRLF
ninevra Jun 14, 2021
c7e4b39
Use SIGINT to kill the server process.
ninevra Jun 15, 2021
37ea991
Mark two FileAPI tests needs-node12
ninevra Jun 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Normalize textarea form value with lf, not crlf
  • Loading branch information
@ninevra
ninevra committed Jun 14, 2021
commit 2b89f7417eb810ac069ae239ac56b0b3e66e2f59
4 changes: 2 additions & 2 deletions lib/jsdom/living/nodes/HTMLTextAreaElement-impl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const { mixin } = require("../../utils");

const DOMException = require("domexception/webidl2js-wrapper");
const { cloningSteps } = require("../helpers/internal-constants");
const { isDisabled, normalizeToCRLF, getLabelsForLabelable, formOwner } = require("../helpers/form-controls");
const { isDisabled, getLabelsForLabelable, formOwner } = require("../helpers/form-controls");
const { childTextContent } = require("../helpers/text");
const { fireAnEvent } = require("../helpers/events");

Expand Down Expand Up @@ -39,7 +39,7 @@ class HTMLTextAreaElementImpl extends HTMLElementImpl {
// https://html.spec.whatwg.org/multipage/form-elements.html#textarea-wrapping-transformation
_getValue() {
// Hard-wrapping omitted, for now.
return normalizeToCRLF(this._rawValue);
return this._getAPIValue();
}

_childTextContentChangeSteps() {
Expand Down