Repository navigation
Conversation
With --debug=frozen-string-literal, modifying a string range endpoint in interpreted code reports where the string was created, but compiled code only says "can't modify frozen String". The IR operands already carry the file and line; the JIT and AOT range paths just didn't pass them along. Follow-up to jruby#9838
headius
reviewed
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to @headius's review on #9838.
As far as I can tell, the file on a string literal's
FrozenStringis always filled in from the scope, and #9838 fixed the one place that wasn't. What's debug-only is the runtime side, which uses the file and line to say where a frozen string was created when you modify it under--debug=frozen-string-literal. That works for string range endpoints in the interpreter, but compiled code dropped the location:The
Rangeoperand already has the file and line on both endpoints, so this passes them throughValueCompiler#pushRangetoRangeObjectSitefor invokedynamic and tonewFrozenStringFromRawfor AOT. Each endpoint keeps its own line, in case the range spans lines. Without the debug flag,newFrozenStringignores the file and line, so nothing changes there.The new spec puts the endpoints on separate lines and checks that both messages include where they were created. It fails in JIT and AOT mode before this change and passes in all four modes after it. The full compiler spec passes with and without invokedynamic.