Repository navigation
Raise TypeError in system when the fiber scheduler's process_wait returns nil - #9843
Open
sampokuokkanen wants to merge 1 commit into
Open
sampokuokkanen wants to merge 1 commit into
sampokuokkanen wants to merge 1 commit into
Conversation
…urns nil When the fiber scheduler's process_wait returned nil, Kernel#system cast the missing exit status to Process::Status and failed with a Java ClassCastException. MRI's rb_f_system checks the type and raises TypeError, so do the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the fiber scheduler's process_wait returned nil, Kernel#system cast the missing exit status to Process::Status and failed with a Java ClassCastException. MRI's
rb_f_systemchecks the type and raises TypeError.typeError(context, nil, ...)would say NilClass so the message is spelled out.