Repository navigation
Conversation
A call with a braceless hash argument whose key is not a plain symbol,
such as h.merge("a" => 1), set the keywords flag but did not pass a
literal symbol-keyed hash as its last argument. The direct keyword
path in compileCallCommon cast that argument to Hash anyway, so the
JIT threw ClassCastException and the method stayed interpreted.
Take the direct path only when the last argument is a literal hash
whose keys are all symbols, and use the normal call path otherwise.
Fixes jruby#9814
sferik
force-pushed
the
jit-braceless-hash-keywords
branch
from
October 17, 2026 12:46
39018e2 to
d343166
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A call with a braceless hash argument whose key isn’t a plain symbol, such as
h.merge("a" => 1), sets the keywords flag, but its last argument is a temporary variable, not a literaloperands.Hash. The direct keyword-argument path incompileCallCommon(added in #9219) cast that argument toHashanyway. The cast threwClassCastException, so the method could never be JIT-compiled and ran in the interpreter for good.This change takes the direct path only when the last argument is a literal hash whose keys are all symbols. Every other call goes through the normal call path, as it did in 10.0.7. Checking for a
Hashalone isn’t enough, becausecompileCallWithKeywordsalso casts each key toSymbol.The new spec in
spec/compiler/general_spec.rbcovers each failing form from the issue, a mixed positional/keyword call, and a call inside a block. Before this change it fails in JIT mode with theClassCastException; after it, it passes in all four modes.