Repository navigation
Make socket "accept" methods dont block fibers (Fiber::Scheduler support) - #9813
Open
albertalef wants to merge 2 commits into
Open
albertalef wants to merge 2 commits into
albertalef wants to merge 2 commits into
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The accept (and sysaccept for servers) methods of ServerSocket, TCPServer and UNIXServer were blocking the fiber threads until some client connects, never calling the io_wait.
When a client in another fiber tries to connect on, using the same scheduler, it never run, blocking the thread permanently.
Now they try a nonblocking accept, and while nothing is pending, wait on scheduler io_wait without holding any lock.
The io_wait result is handled as in "rb_io_maybe_wait_readable", and the server closing interrupts a waiting fiber as in #9760. Without a scheduler, the extra cost is one FiberScheduler.current call.
It also fixes 3 existing bugs around these methods:
The new specs passes on MRI 3.4 and 4.0. This test
test/async/grpc/client.rbof async-grpc was hanging.But now it passes together with #9805 of @sampokuokkanen.