Repository navigation
Use SOURCE retention for @CRuby - #9812
Merged
Merged
Conversation
Nothing reads @cruby at runtime, and RUNTIME retention adds about 17k to lib/jruby.jar. Agreed on jruby#9804: jruby#9804 (comment) jruby#9804 (comment) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
headius
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9804. kares suggested
RetentionPolicy.SOURCEfor@CRuby, and headius agreed: nothing reads the annotation at runtime yet, and keeping it costs about 17k inlib/jruby.jar.@CRubyand its@CRuby.Listcontainer both move fromRUNTIMEtoSOURCE.RUNTIMEif a tool needs to read it from a live JRuby.Checked that nothing in
core,tool,specortestreads it reflectively. A class using a repeated@CRubycompiles and no longer has aRuntimeVisibleAnnotationsentry.🤖 Generated with Claude Code