Repository navigation
Wake Queue#pop(timeout:) waiters when the queue is closed - #9791
Merged
Merged
Conversation
The timed poll loop only checked the item count, so the signal from closeInternal woke the waiter, it found the queue still empty, and went back to awaitNanos until the full timeout passed. A closed, empty queue now returns nil at once and passes the wakeup on to the next consumer, as takeInternal already does for the untimed pop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The timed poll loop only checked the item count, so the signal from closeInternal woke the waiter, it found the queue still empty, and went back to awaitNanos until the full timeout passed. A closed, empty queue now returns nil at once and passes the wakeup on to the next consumer, as takeInternal already does for the untimed pop.
Run into this while trying to run ONCE Campfire: https://github.com/basecamp/once-campfire/blob/05c5a2c0d72f7fd74d7c2ace23cc123000f956b9/lib/rails_ext/sqlite_wal_checkpoint.rb#L41-L49 and hit the
"SQLite WAL checkpointer did not stop within #{timeout}s"error.