[fix] escape shell metachars in chdir: to prevent injection#9464
Open
kares wants to merge 1 commit into
Open
Conversation
PopenExecutor constructs a "cd '<dir>'; ..." for the chdir: option in
spawn/system/IO.popen; the directory path was embedded in single quotes
without escaping, allowing single-quote breakout and arbitrary command
injection:
system('echo hello', chdir: "x'; touch /tmp/pwned; echo '")
MRI uses the POSIX chdir syscall directly and is not affected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PopenExecutor constructs a "cd '
'; ..." for the chdir: option in spawn/system/IO.popen; the directory path was embedded in single quotes without escaping, allowing single-quote breakout and arbitrary command injection:system('echo hello', chdir: "x'; touch /tmp/pwned; echo '")
MRI uses the POSIX chdir syscall directly and is not affected
(cherry-pick with conflict resolution from #9451)