Skip to content

Mask native elements for MRI backtrace #9155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
headius wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Draft

Mask native elements for MRI backtrace #9155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
MRI backtrace should not include native lines 
At some point, we started including native .java lines in the MRI-
formatted trace. This was probably unintended, since MRI-format
traces should always follow CRuby's standard of replacing native
call frames with the most recent Ruby frame.

See #9154 for some discussion of filtering and omitting
internal frames (that PR is about Ruby, but the same filtering
already applied to native frames used in `caller`).

This patch uses the same backtrace gathering logic for the MRI
format as it does for `caller`, since in both cases users expect
not to see .java frames for internal methods, and now with Ruby 4.0
they will also expect not to see internal Ruby sources.
  • Loading branch information
@headius
headius committed Jan 6, 2026
commit dc7674ae4428d12922f6efe43dedd2667d518020
4 changes: 2 additions & 2 deletions core/src/main/java/org/jruby/runtime/backtrace/TraceType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ public static TraceType traceTypeFor(String style) {
else if (style.equalsIgnoreCase("ruby_framed")) return new TraceType(Gather.NORMAL, Format.JRUBY);
else if (style.equalsIgnoreCase("normal")) return new TraceType(Gather.NORMAL, Format.JRUBY);
else if (style.equalsIgnoreCase("full")) return new TraceType(Gather.FULL, Format.JRUBY);
else if (style.equalsIgnoreCase("mri")) return new TraceType(Gather.NORMAL, Format.MRI);
else if (style.equalsIgnoreCase("mri")) return new TraceType(Gather.CALLER, Format.MRI);
else return new TraceType(Gather.NORMAL, Format.JRUBY);
}

Expand Down Expand Up @@ -228,7 +228,7 @@ public BacktraceData getBacktraceData(ThreadContext context, Stream<StackWalker.
},

/**
* Normal Ruby-style backtrace, showing only Ruby and core class methods.
* Normal JRuby-style backtrace, showing internal and external Ruby lines and bound core class methods.
*/
NORMAL {
public BacktraceData getBacktraceData(ThreadContext context, Stream<StackWalker.StackFrame> stackStream) {
Expand Down
Loading