-
-
Notifications
You must be signed in to change notification settings - Fork 941
Quick stab and limited profile runtime #8893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
enebo
wants to merge
4
commits into
master
Choose a base branch
from
topic/profile_embed
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Quick stab and limited profile runtime
This was quickest and minimal needed to work to get a profile which
can load a Ruby runtime. It is not really correct and is meant as a
starting point.
There are some obvious problems with profile as it is defined. Basic
fundamental things like primal Exception types need to be loaded. Allowing
people to omit them is a footgun.
There is obvious issues with ommitting jruby/kernel. Some of that is
required but at the same time it likely hits profile excluded types.
Regex is a major source of DOS so it must be excludable but at the same
time I suspect we call it many places internally.
Methods which use types which are excludable (like Regexp) probably should
be aware of excluded types and not bind. This would be a MAJOR amount of
work but it would fit into idea of a dependency graph. Likewise we could
make a much smarter type declaration where something like:
```java
return defineClass(context, "Integer", Numeric, NOT_ALLOCATABLE_ALLOCATOR).
reifiedClass(RubyInteger.class).
kindOf(new RubyModule.JavaClassKindOf(RubyInteger.class)).
classIndex(ClassIndex.INTEGER).
defineMethods(context, RubyInteger.class).
tap(c-> c.singletonClass(context).undefMethods(context, "new"));
```
(we are only pretending with this example as Integer is too primal to Ruby
to be allowed to be excluded) we would want to add something to this which
would know that it cannot defineClass unless "Numeric" has been defined.
```java
return requires("Numeric", "Fixnum", "Bignum").
defineClass(context, "Integer", Numeric, NOT_ALLOCATABLE_ALLOCATOR).
reifiedClass(RubyInteger.class).
kindOf(new RubyModule.JavaClassKindOf(RubyInteger.class)).
classIndex(ClassIndex.INTEGER).
defineMethods(context, RubyInteger.class).
tap(c-> c.singletonClass(context).undefMethods(context, "new"));
```
This would end up simplifying the smattering of if's in Ruby to just declare
these dependencies in the setup method for the type.- Loading branch information
commit d3bde22d8f0d21f25cbe91867291b8567b0fe57b
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe call it
RestrictedProfileto match the name the test has?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NinekoTheCat sure. I can change this name in the test. Ultimately this class may get very small as we continue.