Skip to content

Docs: Remove links to Web Archive from source - #4991

Merged
mgol merged 1 commit into
jquery:mainfrom
mgol:web-archive-links-removal
Jan 4, 2022
Merged

mgol merged 1 commit into
jquery:mainfrom
mgol:web-archive-links-removal

Conversation

@mgol

@mgol mgol commented Jan 3, 2022 •

Copy link
Copy Markdown
Member

Summary

Neither of the removed links is crucial; one of them refers to a site that has
since started being malicious; while the Web Archive links remain safe, some
scanners warn about such links. Removing them is the safest thing to do.

Fixes gh-4981

Checklist

  • New tests have been added to show the fix or feature works
  • Grunt build and unit tests pass locally with these changes
  • If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com

@mgol mgol added this to the 3.6.1 milestone Jan 3, 2022
@mgol mgol self-assigned this Jan 3, 2022
@mgol mgol added the Docs label Jan 3, 2022
@mgol
mgol requested a review from timmywil January 3, 2022 13:19
@mgol
mgol force-pushed the web-archive-links-removal branch from f9233cf to c8fa248 Compare January 3, 2022 14:05
@sileclercq

Copy link
Copy Markdown

any idea when this fix will get in ? which version is this expected to be on ? is there a way to get a 3.6.1 with just this change ?

Neither of the removed links is crucial; one of them refers to a site that has
since started being malicious; while the Web Archive links remain safe, some
scanners warn about such links. Removing them is the safest thing to do.

Fixes jquerygh-4981
@mgol
mgol force-pushed the web-archive-links-removal branch from c8fa248 to ec5d22a Compare January 4, 2022 15:30
@mgol mgol removed the Needs review label Jan 4, 2022
@mgol
mgol merged commit e24f2dc into jquery:main Jan 4, 2022
@mgol
mgol deleted the web-archive-links-removal branch January 4, 2022 15:33
mgol added a commit that referenced this pull request Jan 4, 2022
Neither of the removed links is crucial; one of them refers to a site that has
since started being malicious; while the Web Archive links remain safe, some
scanners warn about such links. Removing them is the safest thing to do.

Fixes gh-4981
Closes gh-4991

(cherry picked from commit e24f2dc)
@mgol

mgol commented Jan 4, 2022

Copy link
Copy Markdown
Member Author

Landed on main in e24f2dc and on 3.x-stable in 4b0d890.

@mgol

mgol commented Jan 4, 2022

Copy link
Copy Markdown
Member Author

@sileclercq It will be included in jQuery 3.6.1 as can be seen by looking at the Milestone field. We don't plan any special release just with this patch as this is not an actual vulnerability.

timmywil added a commit to timmywil/jquery that referenced this pull request Jan 6, 2022
timmywil added a commit to timmywil/jquery that referenced this pull request Jan 7, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

Invalid links exist in jquery

3 participants