Simplify units before returning numeric value#902
Conversation
|
#903 explains the test issue, which appears as |
|
Thanks @AlexanderBeyn for this fix ! And sorry for the late reply - I'm just back from holidays. One question: shouldn't |
|
You're absolutely right. I've updated the pull request to use |
|
Thanks for updating. The code looks ok, though the unit test that you've added for this specific use case is failing, can you check that out? |
|
I've changed to use mass squared instead of length squared for the units, but this test still feels brittle because of the issue described in #903. |
|
Thanks for the fix. The non-deterministic behavior of units indeed make unit tests a bit fragile :( |
This should close #901 . There is a separate issue breaking unit tests when run all at once, which I'll be filing shortly.