fix(sin): Update to latest complex.js to improve sin(z) for small im(z)#2525
Merged
Conversation
Collaborator
Author
|
@yifanwww, the update to complex.js seems to have improved the situation for sin(a+bi) for b very small. However, there is still one test case of lgamma -- the one where I left the CEPSILON in place in this branch -- where lgamma still does not even have 1e-9 accuracy. It would be much appreciated if you could look into that sometime, especially given how the other cases of inaccuracy in lgamma led to uncovering a bug elsewhere in mathjs (and ultimately complex.js). Thanks! |
josdejong
approved these changes
Apr 13, 2022
Owner
josdejong
left a comment
There was a problem hiding this comment.
Looks good Glen, thanks!
I suppose any additional improvements in lgamma can be addressed separately from this PR? I think it's ready to merge.
Contributor
|
@gwhitney got it, and thanks! I'll check that test case if I have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2523.