Skip to content

Add a queue for hotreload to group changes to fix #2577 #2583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jknack merged 3 commits into from
May 10, 2022
Merged

Add a queue for hotreload to group changes to fix #2577 #2583

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1da6d9
Add a queue for hotreload to group changes
agentgt May 9, 2022
89cc4af
Fix unit test for new jooby run for wait time
agentgt May 9, 2022
d0b1a4a
Make sonatype-lift happy
agentgt May 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Make sonatype-lift happy
  • Loading branch information
@agentgt
agentgt committed May 9, 2022
commit d0b1a4acc3f8ed7e771a65203e5e62018b7e41db
1 change: 1 addition & 0 deletions modules/jooby-run/src/main/java/io/jooby/run/JoobyRun.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,7 @@ public boolean addResource(Path path) {
*
* @throws Throwable If something goes wrong.
*/
@SuppressWarnings("FutureReturnValueIgnored")
public void start() throws Throwable {
this.watcher = newWatcher();
try {
Expand Down
6 changes: 3 additions & 3 deletions modules/jooby-run/src/main/java/io/jooby/run/JoobyRunOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,16 +91,16 @@ public void setPort(Integer port) {
/**
* How long to wait after last file change to restart. Default is: <code>500</code> milliseconds.
*
* @return Wait time in milliseconds
* @return Wait time in milliseconds.
*/
public Long getWaitTimeBeforeRestart() {
return waitTimeBeforeRestart;
}

/**
* Set wait time before restart.
* Set wait time before restart on file change.
*
* @param waitTimeBeforeRestart
* @param waitTimeBeforeRestart the time in milliseconds.
*/
public void setWaitTimeBeforeRestart(Long waitTimeBeforeRestart) {
if (waitTimeBeforeRestart != null) {
Expand Down