Skip to content

pac4j-module: Can't apply a client directly to a POST route. Fix #1972 - #2023

Merged
jknack merged 1 commit into
2.xfrom
1972
Sep 28, 2020
Merged

jknack merged 1 commit into
2.xfrom
1972

Conversation

@jknack

@jknack jknack commented Sep 28, 2020

Copy link
Copy Markdown
Member

No description provided.

@jknack jknack added this to the 2.9.1 milestone Sep 28, 2020
@jknack
jknack requested a review from imeszaros September 28, 2020 00:47

@imeszaros imeszaros left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It definitely fixes the issue, but is there any chance that other http methods needs to be covered too? I'm not sure what are the use cases when you register a client directly against a route instead of a decorator.

@jknack

jknack commented Sep 28, 2020

Copy link
Copy Markdown
Member Author

It definitely fixes the issue, but is there any chance that other http methods needs to be covered too?

Probably, but we won't extend this to any other method.

This is just for very simple use cases where direct client is necessary (no session, redirect in the middle) that is why GET and POST are ok. Filter/decorator is for more complex uses cases.

@imeszaros

Copy link
Copy Markdown
Member

This is just for very simple use cases where direct client is necessary (no session, redirect in the middle) that is why GET and POST are ok. Filter/decorator is for more complex uses cases.

In this case i think it's good to go!

@jknack
jknack merged commit 0960d75 into 2.x Sep 28, 2020
@jknack
jknack deleted the 1972 branch March 23, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants