Repository navigation
Ability to match request locale and use it for templates - #2019
Merged
Merged
Conversation
imeszaros
marked this pull request as draft
September 24, 2020 00:31
Member
|
Looks very good. |
imeszaros
commented
Sep 27, 2020
imeszaros
commented
Sep 27, 2020
Member
Author
|
I added the tests. I think it's ok but there is a strange behavior I commented above. This language matching concept is not very straightforward for me. |
imeszaros
marked this pull request as ready for review
September 27, 2020 01:04
Member
Author
|
Ok I read through RFC 4647 and actually it's not mandatory that filter returns an ordered list:
So i read the source of |
jknack
reviewed
Sep 27, 2020
Member
|
just one change and we are ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
May close #2006
I need to write test cases and test it more, but what do you think?
I didn't find any way to set the locale for rocker and handlebars.