Skip to content

cleanup-jooby-cassandra #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jknack merged 1 commit into from
Jun 25, 2018
Merged

cleanup-jooby-cassandra #1174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions modules/jooby-cassandra/src/main/java/org/jooby/cassandra/Cassandra.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,11 +473,11 @@ public class Cassandra implements Module {

private BiConsumer<Cluster, Config> cc;

private String db;
private final String db;

@SuppressWarnings("rawtypes")

private List<Class> accesors = new ArrayList<>();
private final List<Class> accesors = new ArrayList<>();

private Supplier<Cluster.Builder> builder = Cluster::builder;

Expand Down Expand Up @@ -613,9 +613,7 @@ public void configure(final Env env, final Config conf, final Binder binder) {
ServiceKey serviceKey = env.serviceKey();

Throwing.Function3<Class, String, Object, Void> bind = (type, name, value) -> {
serviceKey.generate(type, name, k -> {
binder.bind(k).toInstance(value);
});
serviceKey.generate(type, name, k -> binder.bind(k).toInstance(value));
return null;
};

Expand Down
2 changes: 1 addition & 1 deletion modules/jooby-cassandra/src/main/java/org/jooby/cassandra/CassandraMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ class CassandraMapper implements Mapper<Object> {
@SuppressWarnings({"unchecked", "rawtypes"})
private static class DeferredHandler implements Deferred.Initializer0 {

private ListenableFuture future;
private final ListenableFuture future;

public DeferredHandler(final ListenableFuture future) {
this.future = future;
Expand Down
4 changes: 2 additions & 2 deletions modules/jooby-cassandra/src/main/java/org/jooby/cassandra/CassandraSessionStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,9 +318,9 @@ public class CassandraSessionStore implements Store {

private final Throwing.Function<String, PreparedStatement> insertSQL;

private Throwing.Function<String, PreparedStatement> selectSQL;
private final Throwing.Function<String, PreparedStatement> selectSQL;

private Throwing.Function<String, PreparedStatement> deleteSQL;
private final Throwing.Function<String, PreparedStatement> deleteSQL;

public CassandraSessionStore(final com.datastax.driver.core.Session session, final int timeout) {
this.session = requireNonNull(session, "Session required.");
Expand Down
6 changes: 3 additions & 3 deletions modules/jooby-cassandra/src/main/java/org/jooby/cassandra/ConnectionString.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,11 +215,11 @@ class ConnectionString {
public static final String SCHEMA = "cassandra://";
private static final String SAMPLE = SCHEMA + "host[, host]*[:port]/keyspace";

private String[] address;
private final String[] address;

private int port;
private final int port;

private String keyspace;
private final String keyspace;

private ConnectionString(final String[] address, final int port, final String keyspace) {
this.address = address;
Expand Down
2 changes: 1 addition & 1 deletion modules/jooby-cassandra/src/main/java/org/jooby/cassandra/Datastore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@
*/
@SuppressWarnings({"rawtypes", "unchecked" })
public class Datastore {
private MappingManager manager;
private final MappingManager manager;

Datastore(final MappingManager manager) {
this.manager = manager;
Expand Down